Re: [PATCH 2/6] hw/pci-host/sabre: Remove superfluous address range check

Mon, 19 Oct 2020 12:02:55 -0700 

On 12/10/2020 18:09, Philippe Mathieu-Daudé wrote:


The region is registered as 64KiB in sabre_init():

     memory_region_init_io(&s->sabre_config, OBJECT(s), &sabre_config_ops, s,
                           "sabre-config", 0x10000);

Remove the superfluous check.

Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
  hw/pci-host/sabre.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/pci-host/sabre.c b/hw/pci-host/sabre.c
index 3634f8369b7..0889c9369f6 100644
--- a/hw/pci-host/sabre.c
+++ b/hw/pci-host/sabre.c
@@ -120,7 +120,7 @@ static void sabre_config_write(void *opaque, hwaddr addr,
trace_sabre_config_write(addr, val); - switch (addr & 0xffff) { 
+    switch (addr) {
      case 0x30 ... 0x4f: /* DMA error registers */
          /* XXX: not implemented yet */
          break;
@@ -197,7 +197,7 @@ static uint64_t sabre_config_read(void *opaque,
      SabreState *s = opaque;
      uint32_t val;
- switch (addr & 0xffff) { 
+    switch (addr) {
      case 0x30 ... 0x4f: /* DMA error registers */
          val = 0;
          /* XXX: not implemented yet */


Reviewed-by: Mark Cave-Ayland <[email protected]>


ATB,

Mark.

Reply via email to