On Tue, Oct 13, 2020 at 10:08:56AM +0200, Thomas Huth wrote: > On 18/09/2020 15.29, Daniel P. Berrangé wrote: > > This job is advisory since it is expected that certain patches will fail > > the style checks and checkpatch.pl provides no way to mark exceptions to > > the rules. > > > > Signed-off-by: Daniel P. Berrangé <[email protected]> > > --- > > .gitlab-ci.d/check-patch.py | 48 +++++++++++++++++++++++++++++++++++++ > > .gitlab-ci.yml | 12 ++++++++++ > > 2 files changed, 60 insertions(+) > > create mode 100755 .gitlab-ci.d/check-patch.py > [...] > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > index a18e18b57e..3ed724c720 100644 > > --- a/.gitlab-ci.yml > > +++ b/.gitlab-ci.yml > > @@ -369,3 +369,15 @@ check-crypto-only-gnutls: > > variables: > > IMAGE: centos7 > > MAKE_CHECK_ARGS: check > > + > > + > > +check-patch: > > + stage: test > > Would it be ok to move this to the "build" stage, so that the job does not > have to wait for all the slow build jobs to finish? > (same question applies for the next patch, too) > > If you agree, I can do the change when picking up the patches, no need to > resend just because of this.
Sure, fine with me. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
