Eduardo Habkost <[email protected]> 于2020年10月9日周五 上午4:31写道： > > Fix the following crash: > > $ qemu-system-x86_64 -object can-host-socketcan,id=obj0 > Segmentation fault (core dumped) > > Signed-off-by: Eduardo Habkost <[email protected]>
Reviewed-by: Li Qiang <[email protected]> > --- > Cc: Pavel Pisa <[email protected]> > Cc: Vikram Garhwal <[email protected]> > Cc: Jason Wang <[email protected]> > Cc: [email protected] > --- > net/can/can_socketcan.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c > index 92b1f79385..4b68f60c6b 100644 > --- a/net/can/can_socketcan.c > +++ b/net/can/can_socketcan.c > @@ -194,6 +194,11 @@ static void can_host_socketcan_connect(CanHostState *ch, > Error **errp) > struct sockaddr_can addr; > struct ifreq ifr; > > + if (!c->ifname) { > + error_setg(errp, "'if' property not set"); > + return; > + } > + > /* open socket */ > s = qemu_socket(PF_CAN, SOCK_RAW, CAN_RAW); > if (s < 0) { > -- > 2.26.2 > >
