On 05/10/20 09:51, Philippe Mathieu-Daudé wrote: > Is that why your "configure: fix performance regression due to PIC > objects" patch has been dropped from your pull request?
Partly. Regarding this particular failure, since Richard's capstone patches are being merged, I think it's easier to do the same with slirp and libfdt and drop the submodule rules from the makefile altogether. Then we can merge safely "configure: fix performance regression due to PIC objects" and also simplify the CFLAGS/LDFLAGS patches. Second, I am hoping that https://github.com/mesonbuild/meson/pull/7760 gets in 0.56.0; then the fix can be simply diff --git a/meson.build b/meson.build index 1dd3f49011..d29b9d41db 100644 --- a/meson.build +++ b/meson.build @@ -1,6 +1,6 @@ project('qemu', ['c'], meson_version: '>=0.55.0', - default_options: ['warning_level=1', 'c_std=gnu99', 'cpp_std=gnu++11', - 'b_colorout=auto'], + default_options: ['warning_level=1', 'c_std=gnu99', 'cpp_std=gnu++11', 'b_colorout=auto'] + + (meson.version().version_compare('>=0.56.0') ? ['b_staticpic=false'] : []), version: run_command('head', meson.source_root() / 'VERSION').stdout().strip()) not_found = dependency('', required: false) Paolo
