Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: [email protected] Subject: [PULL 00/26] migration and friends queue === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 786afbf virtiofsd: Add -o allow_direct_io|no_allow_direct_io options b4e3d2f virtiofsd: Used glib "shared" thread pool 5c6cf53 virtiofsd: document cache=auto default b0a5d54 monitor: Use LOCK_GUARD macros 88b31e8 migration/tls: add trace points for multifd-tls 42dd844 migration/tls: add support for multifd tls-handshake 0dd99f4 migration/tls: extract cleanup function for common-use e951359 migration/tls: add tls_hostname into MultiFDSendParams 652dea8 migration/tls: extract migration_tls_client_create for common-use d70fc72 migration/tls: save hostname into MigrationState cb0c3a3 migration: increase max-bandwidth to 128 MiB/s (1 Gib/s) b4f2d50 migration: Truncate state file in xen-save-devices-state 7448415 migration/dirtyrate: Add trace_calls to make it easier to debug aa44e3a migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function 9a1f005 migration/dirtyrate: Implement calculate_dirtyrate() function f1bfba7 migration/dirtyrate: Implement set_sample_page_period() and is_sample_period_valid() cb3b7ff migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE a82b646 migration/dirtyrate: Compare page hash results for recorded sampled page 7d0f4d2 migration/dirtyrate: Record hash results for each sampled page 8a90389 migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h 539c0d7 migration/dirtyrate: Add dirtyrate statistics series functions 421892b migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info cab1614 migration/dirtyrate: add DirtyRateStatus to denote calculation status 83826ff migration/dirtyrate: setup up query-dirtyrate framwork c58f028 migration: Rework migrate_send_rp_req_pages() function 012226f migration: Properly destroy variables on incoming side === OUTPUT BEGIN === 1/26 Checking commit 012226fcacb7 (migration: Properly destroy variables on incoming side) 2/26 Checking commit c58f0286fdde (migration: Rework migrate_send_rp_req_pages() function) WARNING: Block comments use a leading /* on a separate line #32: FILE: migration/migration.c:317: +/* Request one page from the source VM at the given start address. total: 0 errors, 1 warnings, 89 lines checked Patch 2/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/26 Checking commit 83826ffcaf74 (migration/dirtyrate: setup up query-dirtyrate framwork) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #20: new file mode 100644 total: 0 errors, 1 warnings, 71 lines checked Patch 3/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/26 Checking commit cab161480dd1 (migration/dirtyrate: add DirtyRateStatus to denote calculation status) 5/26 Checking commit 421892b2ce34 (migration/dirtyrate: Add RamblockDirtyInfo to store sampled page info) 6/26 Checking commit 539c0d7abcf0 (migration/dirtyrate: Add dirtyrate statistics series functions) 7/26 Checking commit 8a9038992bc0 (migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h) ERROR: Macros with multiple statements should be enclosed in a do - while loop #67: FILE: migration/ram.h:42: +#define RAMBLOCK_FOREACH_NOT_IGNORED(block) \ + INTERNAL_RAMBLOCK_FOREACH(block) \ + if (ramblock_is_ignored(block)) {} else ERROR: trailing statements should be on next line #69: FILE: migration/ram.h:44: + if (ramblock_is_ignored(block)) {} else ERROR: Macros with multiple statements should be enclosed in a do - while loop #71: FILE: migration/ram.h:46: +#define RAMBLOCK_FOREACH_MIGRATABLE(block) \ + INTERNAL_RAMBLOCK_FOREACH(block) \ + if (!qemu_ram_is_migratable(block)) {} else ERROR: trailing statements should be on next line #73: FILE: migration/ram.h:48: + if (!qemu_ram_is_migratable(block)) {} else ERROR: braces {} are necessary for all arms of this statement #73: FILE: migration/ram.h:48: + if (!qemu_ram_is_migratable(block)) {} else [...] + if (!qemu_ram_is_migratable(block)) {} else [...] total: 5 errors, 0 warnings, 45 lines checked Patch 7/26 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/26 Checking commit 7d0f4d22333b (migration/dirtyrate: Record hash results for each sampled page) 9/26 Checking commit a82b6464e8aa (migration/dirtyrate: Compare page hash results for recorded sampled page) 10/26 Checking commit cb3b7ff83ca3 (migration/dirtyrate: skip sampling ramblock with size below MIN_RAMBLOCK_SIZE) 11/26 Checking commit f1bfba70ecdd (migration/dirtyrate: Implement set_sample_page_period() and is_sample_period_valid()) 12/26 Checking commit 9a1f0050a876 (migration/dirtyrate: Implement calculate_dirtyrate() function) 13/26 Checking commit aa44e3a85c97 (migration/dirtyrate: Implement qmp_cal_dirty_rate()/qmp_get_dirty_rate() function) 14/26 Checking commit 74484157cf26 (migration/dirtyrate: Add trace_calls to make it easier to debug) 15/26 Checking commit b4f2d50c15a8 (migration: Truncate state file in xen-save-devices-state) 16/26 Checking commit cb0c3a374335 (migration: increase max-bandwidth to 128 MiB/s (1 Gib/s)) 17/26 Checking commit d70fc7217cc7 (migration/tls: save hostname into MigrationState) 18/26 Checking commit 652dea809a4b (migration/tls: extract migration_tls_client_create for common-use) 19/26 Checking commit e951359067b9 (migration/tls: add tls_hostname into MultiFDSendParams) 20/26 Checking commit 0dd99f4db197 (migration/tls: extract cleanup function for common-use) 21/26 Checking commit 42dd8447efd6 (migration/tls: add support for multifd tls-handshake) 22/26 Checking commit 88b31e8e1583 (migration/tls: add trace points for multifd-tls) 23/26 Checking commit b0a5d54e6e3e (monitor: Use LOCK_GUARD macros) 24/26 Checking commit 5c6cf5345c0f (virtiofsd: document cache=auto default) 25/26 Checking commit b4e3d2f9afca (virtiofsd: Used glib "shared" thread pool) 26/26 Checking commit 786afbf48ae9 (virtiofsd: Add -o allow_direct_io|no_allow_direct_io options) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
