On 16/09/20 10:39, Gerd Hoffmann wrote:
> +if config_host.has_key('CONFIG_SPICE')
> + module_ss = ss.source_set()
> + module_ss.add(when: [spice], if_true: [files('spice.c'), spice])
You don't need to have "spice" listed in both sides. It is not needed
in "when" because you are effectively inside an "if spice.found()" that
is written in a weird way; and it is not needed in "if_true" if it is
listed in "when".
So it can be either
module_ss.add(files('spice.c'), spice)
or
module_ss.add(when: spice, if_true: files('spice.c'))
Thanks,
Paolo
> + chardev_modules += { 'spice': module_ss }
> +endif
> +
