Hi!
On 16/09/2020 08.13, Ani Sinha wrote:
> This change adds a unit test to exercize the case when hotplug is disabled
> both for
exercize ==> exercise
(also in the subject, please)
[...]> diff --git a/tests/qtest/bios-tables-test.c
b/tests/qtest/bios-tables-test.c
> index 7632cfe1be..4c834474ad 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -768,6 +768,21 @@ static void test_acpi_piix4_bridge_hotplug(void)
> free_test_data(&data);
> }
>
> +static void test_acpi_piix4_bridge_root_hotplug(void)
> +{
> + test_data data;
> +
> + memset(&data, 0, sizeof(data));
> + data.machine = MACHINE_PC;
> + data.variant = ".hpbrroot";
You could use:
test data = {
.machine = MACHINE_PC;
.variant = ".hpbrroot";
};
... then you don't need the memset() call anymore.
Thomas
