On Tue, 15 Sep 2020 13:03:13 +0300 Vladimir Sementsov-Ogievskiy <[email protected]> wrote:
> 14.09.2020 15:34, Greg Kurz wrote: > > The cas_check_pvr() function has two purposes: > > - finding the "best" logical PVR, ie. the most recent one supported by > > the guest for this CPU type > > - checking if the guest supports the real PVR of this CPU type, which > > is just an optional extra information to workaround the lack of > > support for "compat" mode in PR KVM > > > > This logic doesn't need error reporting, really. If we don't find a > > suitable logical PVR, we return the special value 0 which is definitely > > not a valid PVR. Let the caller decide on whether it should error out > > or not. > > maybe then rename it s/cas_check_pvr/cas_find_compat_pvr/ or something like > this? > Ah yes, since this function doesn't do an actual check anymore, it may be worth changing its name. > > > > This doesn't change the behavior. > > > > Signed-off-by: Greg Kurz <[email protected]> > > Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> > > >
