On 9/14/20 3:44 PM, Stefan Hajnoczi wrote: > On Tue, Aug 11, 2020 at 10:11:58AM +0200, Claudio Fontana wrote: >> Signed-off-by: Claudio Fontana <[email protected]> >> --- >> scripts/checkpatch.pl | 48 ++++++++++++++++++++++++++++++++++++------------ >> 1 file changed, 36 insertions(+), 12 deletions(-) >> >> v2 -> v3 : >> >> * move the check for missing changes to MAINTAINERS and trace-events >> later on, as otherwise the check for in_commit_log will not be done >> on an up to date value, causing fromfile and realfile to not be set, >> and matching unwanted strings inside the commit log. >> >> * Ensure that at least one file name is passed to grep. >> >> >> ---- >> >> v1 -> v2 : >> >> * track the "from" file in addition to the "to" file, >> and grep into both (if they exist), looking for trace.h, trace-root.h >> >> If files are reachable and readable, emit a warning if there is no >> update to trace-events. > > This patch still has an RFC tag. Is it ready to be merged? > > Reviewed-by: Stefan Hajnoczi <[email protected]> >
Hi Stefan, I think it's actually not, I would like to have more testing on it, checking all false positive/false negative cases. I found some issues with it, with false negatives, that I still do not understand. If anybody wants to rework this taking this as starting point, that's good, otherwise I will get back to it when I can.. I am not sure about the "move the check" part in v2 -> v3, and if anybody has more input and can help to understand this aspect, welcome to collaborate on this. Ciao, CLaudio
