Philippe Mathieu-Daudé <[email protected]> 于2020年9月5日周六 上午12:26写道： > > dma_memory_rw() returns a MemTxResult type. > Do not discard it, return it to the caller. > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > include/hw/pci/pci.h | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h > index a221dfb3b08..a85b0bc3c44 100644 > --- a/include/hw/pci/pci.h > +++ b/include/hw/pci/pci.h > @@ -785,8 +785,22 @@ static inline AddressSpace > *pci_get_address_space(PCIDevice *dev) > return &dev->bus_master_as; > } > > -static inline int pci_dma_rw(PCIDevice *dev, dma_addr_t addr, > - void *buf, dma_addr_t len, DMADirection dir) > +/** > + * pci_dma_rw: Read from or write to an address space from PCI device. > + * > + * Return a MemTxResult indicating whether the operation succeeded > + * or failed (eg unassigned memory, device rejected the transaction, > + * IOMMU fault). > + * > + * @dev: #PCIDevice doing the memory access > + * @addr: address within the #PCIDevice address space > + * @buf: buffer with the data transferred > + * @len: the number of bytes to read or write > + * @dir: indicates the transfer direction > + */ > +static inline MemTxResult pci_dma_rw(PCIDevice *dev, dma_addr_t addr, > + void *buf, dma_addr_t len, > + DMADirection dir) > { > return dma_memory_rw(pci_get_address_space(dev), addr, buf, len, > dir, MEMTXATTRS_UNSPECIFIED);
Reviewed-by: Li Qiang <[email protected]> > -- > 2.26.2 > >
