On Thu, Sep 03, 2020 at 02:55:06PM +0200, Philippe Mathieu-Daudé wrote: > On 9/3/20 12:42 AM, Eduardo Habkost wrote: > > This will make the type name constant consistent with the name of > > the type checking macro. > > > > Signed-off-by: Eduardo Habkost <[email protected]> > > --- > > Cc: Paolo Bonzini <[email protected]> > > Cc: Fam Zheng <[email protected]> > > Cc: [email protected] > > --- > > hw/scsi/esp-pci.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c > > index 2ce96dc56e..2b1198380b 100644 > > --- a/hw/scsi/esp-pci.c > > +++ b/hw/scsi/esp-pci.c > > @@ -35,11 +35,11 @@ > > #include "qemu/module.h" > > #include "qom/object.h" > > > > -#define TYPE_AM53C974_DEVICE "am53c974" > > +#define TYPE_PCI_ESP "am53c974" > > We are loosing information helpful to reviewers :(
Considering that the PCI_ESP macro is used in very few places, we can use TYPE_AM53C974 and amAM53C974(). I will do it instead. -- Eduardo
