On 02.09.20 18:52, Richard Henderson wrote: > On 9/2/20 4:16 AM, Helge Deller wrote: >>>> + val = cpu_to_le64(HPPA_TLB_ENTRIES); >>> >>> I guess you don't have a cpu structure here against which you could apply >>> ARRAY_SIZE? >> >> You mean to calculate the number of TLB entries based on the static size >> of an array, e.g. ARRAY_SIZE(struct CPUHPPAState.tlb[256]) ? >> I've replaced it intentionally by a constant, because in a follow-up >> patch to improve the TLB-lookup speed, the array gets replaced by a GTree. > > Ok. > >>> The indented defines are weird. >> >> How/Why? > > Because usually the # is at column 1.
I fixed that up in the last v3 version I just sent. Helge
