Hi Gred, > -----Original Message----- > From: Gerd Hoffmann <[email protected]> > Sent: Monday, August 31, 2020 12:43 PM > To: Sai Pavan Boddu <[email protected]> > Cc: Peter Maydell <[email protected]>; Markus Armbruster > <[email protected]>; 'Marc-André Lureau' > <[email protected]>; Paolo Bonzini <[email protected]>; > Edgar Iglesias <[email protected]>; Francisco Eduardo Iglesias > <[email protected]>; [email protected]; Alistair Francis > <[email protected]>; Eduardo Habkost <[email protected]>; > Ying Fang <[email protected]>; 'Philippe Mathieu-Daudé' > <[email protected]>; Vikram Garhwal <[email protected]>; Paul > Zimmerman <[email protected]> > Subject: Re: [PATCH v4 7/7] Versal: Connect DWC3 controller with virt-versal > > Hi, > > > + unsigned int irq = VERSAL_USB0_IRQ_0; > > + const char intName[] = "dwc_usb3"; > > + qemu_fdt_setprop(s->fdt, name, "interrupt-names", > > + intName, sizeof(intName)); > > + qemu_fdt_setprop_cells(s->fdt, name, "interrupts", > > + GIC_FDT_IRQ_TYPE_SPI, irq, > > + GIC_FDT_IRQ_FLAGS_LEVEL_HI); > > This seems to declare one IRQ in the FDT. > > > + qdev_prop_set_uint32(xhci_dev, "intrs", 4); > > Here you configure 4 IRQs for xhci-sysbus. > > > + sysbus_connect_irq(SYS_BUS_DEVICE(xhci_dev), 0, > > + pic[VERSAL_USB0_IRQ_0]); > > Also a single IRQ only. > > I'm wondering which is correct? Probably one IRQ? Do we need support for > multiple IRQs in xhci-sysbus in the first place? [Sai Pavan Boddu] It should be only one, as others seems to be define for device and OTG modes. I would fix this
Thanks, Sai Pavan > > take care, > Gerd
