On 8/17/20 1:10 PM, Roman Bolshakov wrote:
> On Fri, Aug 14, 2020 at 05:11:21AM -0400, Paolo Bonzini wrote:
>> This shows how to do some "computations" in meson.build using its array
>> and dictionary data structures, and also a basic usage of the sourceset
>> module for conditional compilation.
>>
>> [...]
>> + trace_ss.add(trace_h, trace_c)
>> + if 'CONFIG_TRACE_DTRACE' in config_host
>> + trace_dtrace = custom_target(fmt.format('trace-dtrace', 'dtrace'),
>> + output: fmt.format('trace-dtrace',
>> 'dtrace'),
>> + input: trace_events_file,
>> + command: [ tracetool, group, '--format=d',
>> '@INPUT@' ],
>> + capture: true)
>> + trace_dtrace_h = custom_target(fmt.format('trace-dtrace', 'h'),
>> + output: fmt.format('trace-dtrace', 'h'),
>> + input: trace_dtrace,
>> + command: [ 'dtrace', '-o', '@OUTPUT@',
>> '-h', '-s', '@INPUT@' ])
>> + trace_dtrace_o = custom_target(fmt.format('trace-dtrace', 'o'),
>> + output: fmt.format('trace-dtrace', 'o'),
>> + input: trace_dtrace,
>> + command: [ 'dtrace', '-o', '@OUTPUT@',
>> '-G', '-s', '@INPUT@' ])
>> +
>> + trace_ss.add(trace_dtrace_h, trace_dtrace_o)
>
> The patch conflicts with the latest tracing PULL request,
Which isn't merged ;)
It is simpler for the reviewer to test using a series that
apply on current master.
> object files shouldn't be generated on darwin:
>
> https://lists.gnu.org/archive/html/qemu-devel/2020-08/msg02493.html
>
> Thanks,
> Roman
