On Sat, 8 Aug 2020 at 02:35, Brian Norris <[email protected]> wrote: > > Hello! > > On Wed, Jul 15, 2020 at 11:57:14PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell <[email protected]> > > wrote: > > > > > > On Tue, 16 Jun 2020 at 10:19, Peter Maydell <[email protected]> > > > wrote: > > > > > > > > On Tue, 16 Jun 2020 at 00:00, Joe Slater <[email protected]> > > > > wrote: > > > > > > > > > > Always look for ../share/qemu then ../pc-bios when looking for > > > > > datadir. > > > > > > > > Could you provide some more context, please? Why is this > > > > change useful; presumably we broke some setup in 5.0, but > > > > what exactly ? > > > > > > > > I'm guessing this might be a regression introduced by commit > > > > 6dd2dacedd83d12328 so I'm ccing the relevant people. > > > > > > Marco, Paolo: ping? Another user has just asked me the status > > > of this as they also ran into this regression in what directories > > > we search... > > > > Thanks for the heads-up, I didn't see that bug/mail. Indeed, that > > commit assumed that either we run from a build directory or from an > > installed qemu. It seems this is hybrid approach, which I didn't know > > we supported. I'll check it. > > Add one more to the pile! Chrome OS noticed this when upgrading to > 5.0.0: > > https://bugs.chromium.org/p/chromium/issues/detail?id=1114204#c8 > > I'd love to see this applied to a release.
It's just missed 5.1, unfortunately :-( Marc-André, did you want to review it ? thanks -- PMM
