On Thu, 6 Aug 2020 at 13:21, Cédric Le Goater <[email protected]> wrote: > > The model uses today the "No transmit buffer unavailable" interrupt > status which it is not appropriate. According to the Aspeed specs, no > interrupts are raised in that case. An "AHB error" status seems like a > better modeling choice for all implementations since it is covered by > the Linux kernel.
The datasheet calls it this: NPTXBUF UNAVA: Normal priority transmit buffer unavailable Perhaps we should say this: The model uses today the "Normal priority transmit buffer unavailable" interrupt status which is not appropriate. Reviewed-by: Joel Stanley <[email protected]> > > Cc: Frederic Konrad <[email protected]> > Signed-off-by: Cédric Le Goater <[email protected]> > --- > hw/net/ftgmac100.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/ftgmac100.c b/hw/net/ftgmac100.c > index 5c0fe2d8cb75..014980d30aca 100644 > --- a/hw/net/ftgmac100.c > +++ b/hw/net/ftgmac100.c > @@ -517,7 +517,7 @@ static void ftgmac100_do_tx(FTGMAC100State *s, uint32_t > tx_ring, > if (dma_memory_read(&address_space_memory, bd.des3, ptr, len)) { > qemu_log_mask(LOG_GUEST_ERROR, "%s: failed to read packet @ > 0x%x\n", > __func__, bd.des3); > - s->isr |= FTGMAC100_INT_NO_NPTXBUF; > + s->isr |= FTGMAC100_INT_AHB_ERR; > break; > } > > -- > 2.25.4 >
