Paolo Bonzini <pbonz...@redhat.com> writes:
> On 06/08/20 10:59, Cornelia Huck wrote:
>>> bool stopped = false;
>>> -
>>> + bool bql = !qemu_mutex_iothread_locked();
>>> + if (bql) {
>>> + qemu_mutex_lock_iothread();
>>> + }
>> I'm not sure I like that conditional locking. Can we instead create
>> __s390_cpu_do_interrupt() or so, move the meat of this function there,
>> take the bql unconditionally here, and...
>>
>
> Agreed, except the usual convention would be
> s390_cpu_do_interrupt_locked.
We should probably document this convention in CODING_STYLE.rst/Naming
>
> Paolo
--
Alex Bennée
