On 8/4/20 10:00 AM, Thomas Huth wrote:
> The code currently fails to compile on 32-bit big endian targets:
>
> target/riscv/vector_helper.c: In function 'vext_clear':
> target/riscv/vector_helper.c:154:16: error: cast to pointer from integer
> of different size [-Werror=int-to-pointer-cast]
> memset((void *)((uintptr_t)tail & ~(7ULL)), 0, part1);
> ^
> target/riscv/vector_helper.c:155:16: error: cast to pointer from integer
> of different size [-Werror=int-to-pointer-cast]
> memset((void *)(((uintptr_t)tail + 8) & ~(7ULL)), 0, part2);
> ^
> cc1: all warnings being treated as errors
>
> We should not use "long long" (i.e. 64-bit) values here to avoid the
> problem. Switch to our QEMU_ALIGN_PTR_DOWN/UP macros instead.
>
> Fixes: 751538d5da ("add vector stride load and store instructions")
> Suggested-by: Philippe Mathieu-Daudé <[email protected]>
> Signed-off-by: Thomas Huth <[email protected]>
> ---
> target/riscv/vector_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <[email protected]>
r~
