On Fri, Jul 31, 2020 at 11:27:04AM +0200, Lukas Straub wrote: > yank_register_instance (called when creating the new chardev object) > aborts if the instance already exists. So check for duplicate id before > creating the new chardev to prevent this.
I feel the right answer here is for yank_register_instance to not use abort(). Instead have it take a 'Error **errp' and report the error normally. The caller can then propagate the errors in the same way it does for the duplicate ID errors. If a particular caller can't handle errors gracefully, then it can pass "&error_abort" to the yank_register_instance() to get the same abort semantics as now. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
