On 20-07-30 00:06:36, Klaus Jensen wrote:
> From: Klaus Jensen <k.jen...@samsung.com>
>
> Always destroy the request qsg/iov at the end of request use.
>
> Signed-off-by: Klaus Jensen <k.jen...@samsung.com>
> ---
> hw/block/nvme.c | 52 ++++++++++++++++++++-----------------------------
> 1 file changed, 21 insertions(+), 31 deletions(-)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 3d7275eae369..045dd55376a5 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -217,6 +217,17 @@ static void nvme_req_clear(NvmeRequest *req)
> memset(&req->cqe, 0x0, sizeof(req->cqe));
> }
>
> +static void nvme_req_exit(NvmeRequest *req)
> +{
> + if (req->qsg.sg) {
> + qemu_sglist_destroy(&req->qsg);
> + }
> +
> + if (req->iov.iov) {
> + qemu_iovec_destroy(&req->iov);
> + }
> +}
> +
Klaus,
What is differences between 'clear' and 'exit' from the request
perspective?
Thanks,
