On Wed, 8 Jul 2020 16:36:19 +0200
David Hildenbrand <[email protected]> wrote:
> Let's force virtio version 1. While at it, use qdev_realize() to set
> the parent bus and realize - like most other virtio-*-pci
> implementations.
Yes, there's recently been a mass conversion to qdev_realize().
>
> Fixes: 0b9a2443a48b ("virtio-pci: Proxy for virtio-mem")
> Cc: Cornelia Huck <[email protected]>
> Cc: "Michael S. Tsirkin" <[email protected]>
> Signed-off-by: David Hildenbrand <[email protected]>
> ---
> hw/virtio/virtio-mem-pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/virtio/virtio-mem-pci.c b/hw/virtio/virtio-mem-pci.c
> index 1a8e854123..831022aa86 100644
> --- a/hw/virtio/virtio-mem-pci.c
> +++ b/hw/virtio/virtio-mem-pci.c
> @@ -21,8 +21,8 @@ static void virtio_mem_pci_realize(VirtIOPCIProxy
> *vpci_dev, Error **errp)
> VirtIOMEMPCI *mem_pci = VIRTIO_MEM_PCI(vpci_dev);
> DeviceState *vdev = DEVICE(&mem_pci->vdev);
>
> - qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus));
> - object_property_set_bool(OBJECT(vdev), true, "realized", errp);
> + virtio_pci_force_virtio_1(vpci_dev);
> + qdev_realize(vdev, BUS(&vpci_dev->bus), errp);
> }
>
> static void virtio_mem_pci_set_addr(MemoryDeviceState *md, uint64_t addr,
Reviewed-by: Cornelia Huck <[email protected]>
