Patchew URL: https://patchew.org/QEMU/[email protected]/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH] coverity: provide Coverity-friendly MIN_CONST and MAX_CONST Type: series Message-id: [email protected] === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/[email protected] -> patchew/[email protected] Switched to a new branch 'test' 3aee0de coverity: provide Coverity-friendly MIN_CONST and MAX_CONST === OUTPUT BEGIN === WARNING: architecture specific defines should be avoided #38: FILE: include/qemu/osdep.h:269: +#ifdef __COVERITY__ ERROR: Macros with complex values should be enclosed in parenthesis #39: FILE: include/qemu/osdep.h:270: +#define MIN_CONST(a, b) (a) < (b) ? (a) : (b) ERROR: Macros with complex values should be enclosed in parenthesis #40: FILE: include/qemu/osdep.h:271: +#define MAX_CONST(a, b) (a) > (b) ? (a) : (b) total: 2 errors, 1 warnings, 34 lines checked Commit 3aee0de30ad2 (coverity: provide Coverity-friendly MIN_CONST and MAX_CONST) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/[email protected]/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to [email protected]
