Re: [PATCH v2 20/25] x86: Fix x86_cpu_new() error API violations

[Markus Armbruster]

Paolo Bonzini <pbonz...@redhat.com> writes:

> On 24/06/20 16:17, Igor Mammedov wrote:
>>> -    cpu = object_new(MACHINE(x86ms)->cpu_type);
>>> -
>>> -    object_property_set_uint(cpu, apic_id, "apic-id", &local_err);
>>> -    qdev_realize(DEVICE(cpu), NULL, &local_err);
>>> -
>>> -    object_unref(cpu);
>>> -    error_propagate(errp, local_err);
>>> +    object_property_set_uint(cpu, apic_id, "apic-id", &error_abort);
>> it may fail here if user specified wrong cpu flags, but there is nothing we 
>> can do to fix it.
>> perhaps error_fatal would suit this case better?
>
> No, we need to add the error_propagate dance instead.

Thanks, will dance!