On Tue, 23 Jun 2020, Philippe Mathieu-Daudé wrote:
Since its introduction in commit 6fc7f77fd2 i2c_start_transfer() uses incorrectly the direction of the transfer. Fix it now.Fixes: 6fc7f77fd2 ("introduce aux-bus") Reported-by: BALATON Zoltan <[email protected]> Suggested-by: BALATON Zoltan <[email protected]>
One of the above is probably enough, maybe Reported-by because I wasn't sure what's the solution. I'm also happy with your changes to the whole series, thanks for fixing it.
Regards, BALATON Zoltan
Signed-off-by: Philippe Mathieu-Daudé <[email protected]> --- RFC because untested (probably never was anyway) Cc: Frederic Konrad <[email protected]> Cc: Alistair Francis <[email protected]> Cc: Peter Maydell <[email protected]> --- hw/misc/auxbus.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/misc/auxbus.c b/hw/misc/auxbus.c index cef0d0d6d0..dc4a5dd10d 100644 --- a/hw/misc/auxbus.c +++ b/hw/misc/auxbus.c @@ -141,7 +141,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, i2c_end_transfer(i2c_bus); } - if (i2c_start_transfer(i2c_bus, address, is_write)) { + if (i2c_start_transfer(i2c_bus, address, !is_write)) { ret = AUX_I2C_NACK; break; } @@ -172,7 +172,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, /* * No transactions started.. */ - if (i2c_start_transfer(i2c_bus, address, is_write)) { + if (i2c_start_transfer(i2c_bus, address, !is_write)) { break; } } else if ((address != bus->last_i2c_address) || @@ -181,7 +181,7 @@ AUXReply aux_request(AUXBus *bus, AUXCommand cmd, uint32_t address, * Transaction started but we need to restart.. */ i2c_end_transfer(i2c_bus); - if (i2c_start_transfer(i2c_bus, address, is_write)) { + if (i2c_start_transfer(i2c_bus, address, !is_write)) { break; } }
