On 6/11/20 7:45 AM, Peter Maydell wrote: > Convert the VQRDMLAH and VQRDMLSH insns in the 2-reg-scalar > group to decodetree. ... > +static bool do_vqrdmlah_2sc(DisasContext *s, arg_2scalar *a, > + NeonGenThreeOpEnvFn *opfn) > +{ > + /* > + * VQRDMLAH/VQRDMLSH: this is like do_2scalar, but the opfn > + * performs a kind of fused op-then-accumulate using a helper > + * function that takes all of rd, rn and the scalar at once. > + */ > + TCGv_i32 scalar; > + int pass; > + > + if (!arm_dc_feature(s, ARM_FEATURE_NEON)) { > + return false; > + } > + > + if (!dc_isar_feature(aa32_rdm, s)) { > + return 1; > + }
return false; Otherwise, Reviewed-by: Richard Henderson <richard.hender...@linaro.org> r~