Le 08/06/2020 à 18:43, Filip Bozuta a écrit : > From: Filip Bozuta <filip.boz...@syrmia.com> > > Structure "struct syscallname" in file "strace.c" is used for "-strace" > to print arguments and return values of syscalls. The last field of > this structure "result" represents the calling function that prints the > return values. This field was extended in this patch so that this > functions > takes all syscalls arguments beside the return value. In this way, it > enables > "-strace" to print arguments of syscalls that have changed after the > syscall > execution. This extension will be useful as there are many syscalls that > return values inside their arguments (i.e. listxattr() that returns the > list > of extended attributes inside the "list" argument). > > Implementation notes: > > Since there are already three existing "print_syscall_ret*" functions > inside > "strace.c" ("print_syscall_ret_addr()", "print_syscall_ret_adjtimex()", > "print_syscall_ret_newselect()"), they were changed to have all syscall > arguments > beside the return value. This was done so that these functions don't > cause build > errors (even though syscall arguments are not used in these functions). > > Signed-off-by: Filip Bozuta <filip.boz...@syrmia.com> > --- > linux-user/qemu.h | 4 +++- > linux-user/strace.c | 24 ++++++++++++++++++------ > linux-user/syscall.c | 2 +- > 3 files changed, 22 insertions(+), 8 deletions(-) >
Reviewed-by: Laurent Vivier <laur...@vivier.eu>