> -----Original Message----- > From: Philippe Mathieu-Daudé <[email protected]> > Sent: 08 June 2020 17:00 > To: [email protected] > Cc: [email protected]; Markus Armbruster <[email protected]>; Max Filippov > <[email protected]>; > Marcel Apfelbaum <[email protected]>; Peter Maydell > <[email protected]>; Michael Walle > <[email protected]>; Edgar E. Iglesias <[email protected]>; Aurelien > Jarno > <[email protected]>; Gerd Hoffmann <[email protected]>; Stafford Horne > <[email protected]>; Andrzej > Zaborowski <[email protected]>; [email protected]; Alistair Francis > <[email protected]>; > Richard Henderson <[email protected]>; Mark Cave-Ayland > <[email protected]>; Marc-André > Lureau <[email protected]>; Daniel P . Berrange > <[email protected]>; qemu- > [email protected]; Michael S. Tsirkin <[email protected]>; > [email protected]; Sagar > Karandikar <[email protected]>; Anthony Perard > <[email protected]>; Palmer Dabbelt > <[email protected]>; Stefano Stabellini <[email protected]>; Paul > Durrant <[email protected]>; Paolo > Bonzini <[email protected]>; Alistair Francis <[email protected]>; > Eduardo Habkost > <[email protected]>; Thomas Huth <[email protected]>; Bastian Koppelmann > <[email protected] > paderborn.de>; David Gibson <[email protected]>; Magnus Damm > <[email protected]>; > Philippe Mathieu-Daudé <[email protected]> > Subject: [RFC PATCH 15/35] hw/i386/xen/xen-hvm: Emit warning when old code is > used > > This code hasn't been QOM'ified yet. Warn the user.
"Based on today's IRC chat, this is a trivial RFC series to anotate pre-qdev/QOM devices so developers using them without knowing they are not QOM'ified yet can realize it and convert them if they have time." So, how should this be coded then? The XenIOState doesn't really qualify as a 'device', does it? Paul > > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- > hw/i386/xen/xen-hvm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c > index 82ece6b9e7..a1163b1529 100644 > --- a/hw/i386/xen/xen-hvm.c > +++ b/hw/i386/xen/xen-hvm.c > @@ -31,7 +31,7 @@ > #include "sysemu/xen-mapcache.h" > #include "trace.h" > #include "exec/address-spaces.h" > - > +#include "hw/qdev-deprecated.h" > #include <xen/hvm/ioreq.h> > #include <xen/hvm/e820.h> > > @@ -1401,6 +1401,8 @@ void xen_hvm_init(PCMachineState *pcms, MemoryRegion > **ram_memory) > xen_pfn_t ioreq_pfn; > XenIOState *state; > > + qdev_warn_deprecated_function_used(); > + > state = g_malloc0(sizeof (XenIOState)); > > state->xce_handle = xenevtchn_open(NULL, 0); > -- > 2.21.3
