On Wed, 3 Jun 2020 at 09:26, Andrew Jones <[email protected]> wrote: > The name 'kvm_arm_add_vcpu_properties' says nothing about being specific > to the timer. So this is either the wrong place for this function, or the > function is named wrong. I'd say it's the wrong place, because, as the > comment above kvm_arm_add_vcpu_properties() implies, the function is > for all 'kvm-*' prefixed properties, not just timer related ones. It's > true we don't have any others yet, but we will. I have plans to post > kvm-steal-time soon, and despite it also having 'time' in its name, it > shouldn't depend on ARM_FEATURE_GENERIC_TIMER. > > How about the below [untested] patch instead?
Your patch is the code arrangement I had in mind, yes. -- PMM
