On 6/1/20 8:39 PM, Richard Henderson wrote:
> On 5/20/20 8:42 PM, David Gibson wrote:
>> + if (object_dynamic_cast(obj, TYPE_GUEST_MEMORY_PROTECTION)) {
>> + GuestMemoryProtection *gmpo = GUEST_MEMORY_PROTECTION(obj);
>
> This duplicates the interface check. You should use
>
> gmpo = (GuestMemoryProtection *)
> object_dynamic_cast(obj, TYPE_GUEST_MEMORY_PROTECTION);
> if (gmpo) {
>
> AFICT.
Or ignore this nit, since you clean it up in patch 14.
Reviewed-by: Richard Henderson <[email protected]>
r~
