Re: [PATCH v2 3/5] target/tricore: Raise EXCP_DEBUG in gen_goto_tb() for singlestep

[Richard Henderson]

On 5/29/20 12:21 AM, Bastian Koppelmann wrote:
>          if (ctx->base.singlestep_enabled) {
> -            /* raise exception debug */
> +            generate_qemu_excp(ctx, EXCP_DEBUG);
>          }
>          tcg_gen_exit_tb(NULL, 0);

For preference, put an else here:

  if (singlestep) {
    generate_qemu_excp();
  } else {
    tcg_gen_exit_tb();
  }

else you emit dead code after the exception.

r~