On 6/1/20 12:35 PM, Peter Maydell wrote: > On Mon, 1 Jun 2020 at 08:54, Philippe Mathieu-Daudé <f4...@amsat.org> wrote: >> >> Followed Peter's suggestions: >> >> * delete the unused MmeoryRegionMmio >> * move these typedefs into include/hw/usb.h and rename them >> to MUSBReadFunc and MUSBWriteFunc, since that's all they're >> used for now > >> include/exec/cpu-common.h | 3 --- >> include/exec/memory.h | 6 ----- >> include/hw/usb.h | 30 ------------------------- >> include/hw/usb/musb.h | 47 +++++++++++++++++++++++++++++++++++++++ >> hw/usb/hcd-musb.c | 5 +++-- >> hw/usb/tusb6010.c | 1 + > > I think we usually would give the .h file a name matching the .c file, > so include/hw/usb/hcd-musb.h ?
Indeed, I'll update. > > Either way, whole series: > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Thanks! > > thanks > -- PMM >
