On 12/05/2020 09.08, Philippe Mathieu-Daudé wrote: > On 4/29/20 10:48 AM, chen huacai wrote: >> Hi, Philippe, >> >> On Wed, Apr 29, 2020 at 4:30 PM Philippe Mathieu-Daudé >> <[email protected]> wrote: >>> >>> Refactor duplicated code in a single place. >>> >>> Signed-off-by: Philippe Mathieu-Daudé <[email protected]> >>> --- >>> hw/mips/mips_int.c | 11 +++-------- >>> 1 file changed, 3 insertions(+), 8 deletions(-) >>> >>> diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c >>> index 796730b11d..4a1bf846da 100644 >>> --- a/hw/mips/mips_int.c >>> +++ b/hw/mips/mips_int.c >>> @@ -47,17 +47,12 @@ static void cpu_mips_irq_request(void *opaque, >>> int irq, int level) >>> >>> if (level) { >>> env->CP0_Cause |= 1 << (irq + CP0Ca_IP); >>> - >>> - if (kvm_enabled() && irq == 2) { >>> - kvm_mips_set_interrupt(cpu, irq, level); >>> - } >>> - >>> } else { >>> env->CP0_Cause &= ~(1 << (irq + CP0Ca_IP)); >>> + } >>> >>> - if (kvm_enabled() && irq == 2) { >>> - kvm_mips_set_interrupt(cpu, irq, level); >>> - } >>> + if (kvm_enabled() && irq == 2) { >>> + kvm_mips_set_interrupt(cpu, irq, level); >>> } >>> >>> if (env->CP0_Cause & CP0Ca_IP_mask) { >>> -- >>> 2.21.1
Reviewed-by: Thomas Huth <[email protected]>
