On 14/05/2020 14.37, Janosch Frank wrote:
> If we have a lowcore struct that has members for offsets that we want
> to touch, why not use it?
>
> Signed-off-by: Janosch Frank <fran...@linux.ibm.com>
> ---
> pc-bios/s390-ccw/cio.h | 17 +++++++++++------
> pc-bios/s390-ccw/main.c | 8 +++-----
> 2 files changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
> index aaa432dedd..1ce5344b85 100644
> --- a/pc-bios/s390-ccw/cio.h
> +++ b/pc-bios/s390-ccw/cio.h
> @@ -122,12 +122,17 @@ typedef struct schib {
> } __attribute__ ((packed, aligned(4))) Schib;
>
> typedef struct subchannel_id {
> - __u32 cssid:8;
> - __u32:4;
> - __u32 m:1;
> - __u32 ssid:2;
> - __u32 one:1;
> - __u32 sch_no:16;
> + union {
> + struct {
> + __u16 cssid:8;
> + __u16 reserved:4;
> + __u16 m:1;
> + __u16 ssid:2;
> + __u16 one:1;
> + };
> + __u16 sch_id;
> + };
> + __u16 sch_no;
Wrong indentation for that sch_no line? Should only be 4 spaces,
shouldn't it?
> } __attribute__ ((packed, aligned(4))) SubChannelId;
Thomas
