Hi, Philippe,
On Wed, Apr 29, 2020 at 4:30 PM Philippe Mathieu-Daudé <f4...@amsat.org> wrote:
>
> Refactor duplicated code in a single place.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org>
> ---
> hw/mips/mips_int.c | 11 +++--------
> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
> index 796730b11d..4a1bf846da 100644
> --- a/hw/mips/mips_int.c
> +++ b/hw/mips/mips_int.c
> @@ -47,17 +47,12 @@ static void cpu_mips_irq_request(void *opaque, int irq,
> int level)
>
> if (level) {
> env->CP0_Cause |= 1 << (irq + CP0Ca_IP);
> -
> - if (kvm_enabled() && irq == 2) {
> - kvm_mips_set_interrupt(cpu, irq, level);
> - }
> -
> } else {
> env->CP0_Cause &= ~(1 << (irq + CP0Ca_IP));
> + }
Since the if-else has become one line, so can we remove { and } here?
>
> - if (kvm_enabled() && irq == 2) {
> - kvm_mips_set_interrupt(cpu, irq, level);
> - }
> + if (kvm_enabled() && irq == 2) {
> + kvm_mips_set_interrupt(cpu, irq, level);
> }
>
> if (env->CP0_Cause & CP0Ca_IP_mask) {
> --
> 2.21.1
>
>
--
Huacai Chen
