On 4/14/20 1:06 PM, Alex Bennée wrote:
> From: Philippe Mathieu-Daudé <phi...@redhat.com>
>
> When converted to use GByteArray in commits 462474d760c and
> a010bdbe719, the call to stfq_p() was removed. This call
> serialize a float.
> Since we now use a GByteArray, we can not use stfq_p() directly.
> Introduce the gdb_get_float64() helper to load a float64 register.
>
> Fixes: 462474d760c ("target/m68k: use gdb_get_reg helpers")
> Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
> Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com>
> Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
> Message-Id: <20200414163853.12164-3-phi...@redhat.com>
> ---
> include/exec/gdbstub.h | 11 +++++++++++
> target/m68k/helper.c | 3 ++-
> target/ppc/gdbstub.c | 4 ++--
> target/ppc/translate_init.inc.c | 2 +-
> 4 files changed, 16 insertions(+), 4 deletions(-)
Not for 5.0, please.
As I mentioned in reply to Phil, this is not a bug fix. Unlike the float32 sh4
usage, the places changed properly use gdb_get_reg64().
r~
