Re: [PATCH v9 09/14] iotests: limit line length to 79 chars

[Max Reitz]

On 25.03.20 00:20, John Snow wrote:
> 79 is the PEP8 recommendation. This recommendation works well for
> reading patch diffs in TUI email clients.
> 
> Signed-off-by: John Snow <js...@redhat.com>
> ---
>  tests/qemu-iotests/iotests.py | 64 +++++++++++++++++++++++------------
>  tests/qemu-iotests/pylintrc   |  6 +++-
>  2 files changed, 47 insertions(+), 23 deletions(-)
> 
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index 3a049ece5b..e12d6e533e 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py

[...]

> @@ -537,11 +547,13 @@ def pause_drive(self, drive, event=None):
>              self.pause_drive(drive, "write_aio")
>              return
>          self.qmp('human-monitor-command',
> -                 command_line='qemu-io %s "break %s bp_%s"' % (drive, event, 
> drive))
> +                 command_line='qemu-io %s "break %s bp_%s"'
> +                 % (drive, event, drive))
>  
>      def resume_drive(self, drive):
>          self.qmp('human-monitor-command',
> -                 command_line='qemu-io %s "remove_break bp_%s"' % (drive, 
> drive))
> +                 command_line='qemu-io %s "remove_break bp_%s"'
> +                 % (drive, drive))

Hm.  You didn’t reply on my (second, insisting) question on what stops
us from introducing a variable here (hmp_cmd = 'qemu-io %s ...' % ...;
self.qmp('human-monitor-command', command_line=hmp_cmd)).

:c

Max

signature.asc
Description: OpenPGP digital signature