Gentle ping. Any other suggestions about this?
Thanks. >-----Original Message----- >From: Chenqun (kuhn) >Sent: Wednesday, March 11, 2020 11:29 AM >To: [email protected]; [email protected] >Cc: Zhanghailiang <[email protected]>; Chenqun (kuhn) ><[email protected]>; Euler Robot <[email protected]>; >Kevin Wolf <[email protected]>; Ronnie Sahlberg ><[email protected]>; Paolo Bonzini <[email protected]>; Peter >Lieven <[email protected]>; Max Reitz <[email protected]>; Laurent Vivier ><[email protected]> >Subject: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang >warning > >Clang static code analyzer show warning: > block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read > flags &= ~BDRV_O_RDWR; > ^ ~~~~~~~~~~~~ > >In iscsi_allocmap_init() only checks BDRV_O_NOCACHE, which is the same in >both of flags and bs->open_flags. >We can use the flags instead bs->open_flags to prevent Clang warning. > >Reported-by: Euler Robot <[email protected]> >Signed-off-by: Chen Qun <[email protected]> >Reviewed-by: Kevin Wolf <[email protected]> >--- >Cc: Ronnie Sahlberg <[email protected]> >Cc: Paolo Bonzini <[email protected]> >Cc: Peter Lieven <[email protected]> >Cc: Kevin Wolf <[email protected]> >Cc: Max Reitz <[email protected]> >Cc: Laurent Vivier <[email protected]> > >v1->v2: > Keep the 'flags' then use it(Base on Kevin's comments). > >v2->v3: > Modify subject and commit messages(Base on Kevin's and Laurent's >comments). >--- > block/iscsi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/block/iscsi.c b/block/iscsi.c index 682abd8e09..50bae51700 100644 >--- a/block/iscsi.c >+++ b/block/iscsi.c >@@ -2002,7 +2002,7 @@ static int iscsi_open(BlockDriverState *bs, QDict >*options, int flags, > iscsilun->cluster_size = iscsilun->bl.opt_unmap_gran * > iscsilun->block_size; > if (iscsilun->lbprz) { >- ret = iscsi_allocmap_init(iscsilun, bs->open_flags); >+ ret = iscsi_allocmap_init(iscsilun, flags); > } > } > >-- >2.23.0 >
