On Tue, 17 Mar 2020 00:26:06 +1000 Nicholas Piggin <[email protected]> wrote:
> ppc_cpu_do_system_reset delivers a system rreset interrupt to the guest, > which is certainly not what is intended here. Panic the guest like other > failure cases here do. > > Signed-off-by: Nicholas Piggin <[email protected]> > --- Makes sense. Reviewed-by: Greg Kurz <[email protected]> > hw/ppc/spapr_events.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c > index 2afd1844e4..11303258d4 100644 > --- a/hw/ppc/spapr_events.c > +++ b/hw/ppc/spapr_events.c > @@ -785,7 +785,6 @@ static uint32_t spapr_mce_get_elog_type(PowerPCCPU *cpu, > bool recovered, > static void spapr_mce_dispatch_elog(PowerPCCPU *cpu, bool recovered) > { > SpaprMachineState *spapr = SPAPR_MACHINE(qdev_get_machine()); > - CPUState *cs = CPU(cpu); > uint64_t rtas_addr; > CPUPPCState *env = &cpu->env; > PowerPCCPUClass *pcc = POWERPC_CPU_GET_CLASS(cpu); > @@ -823,8 +822,7 @@ static void spapr_mce_dispatch_elog(PowerPCCPU *cpu, bool > recovered) > /* get rtas addr from fdt */ > rtas_addr = spapr_get_rtas_addr(); > if (!rtas_addr) { > - /* Unable to fetch rtas_addr. Hence reset the guest */ > - ppc_cpu_do_system_reset(cs); > + qemu_system_guest_panicked(NULL); > g_free(ext_elog); > return; > }
