On 3/14/20 11:49 PM, LIU Zhiwei wrote:
>>> + if (offset > vl) { \
>>> + offset = vl; \
>>> + } \
>> This isn't right.
> That's to process a corner case. As you can see the behavior of vslideup.vx
> from Section 17.4.1
>
> 0 < i < max(vstart, OFFSET) unchanged
> max(vstart, OFFSET) <= i < vl vd[i] = vs2[i-OFFSET] if mask enabled,
> unchanged if not
> vl <= i < VLMAX
> tail elements, vd[i] = 0
>
>
> The spec v0.7.1 or v0.8 does not specified when OFFSET > vl.
Certainly it does, right there:
offset <= i < vl.
If offset >= vl, then that range is empty of elements.
> Should The elements (vl <= i < OFFSET) be seen as tail elements, or
> unchanged?
Tail elements.
> Here (vl <= i < OFFSET) elements are seen as tail elements.
Exactly.
>> Again, eliminate vl == 0 first. In fact, why don't we make that a global
>> request for all of the patches for the next revision.
> I don't get it.
>
> Check vl == 0 first for all patches. Is it right?
Yes.
r~
