Re: [PATCH v9 09/15] s390x: protvirt: Set guest IPL PSW

[Christian Borntraeger]

On 13.03.20 15:21, Janosch Frank wrote:
[..]
>>> +    } else {
>>> +        s390_cpu_set_state(S390_CPU_STATE_LOAD, cpu);
>>> +    }
>>>      s390_cpu_set_state(S390_CPU_STATE_OPERATING, cpu);
>>>  }
>>>  #endif
>>
>> I don't understand why you set the state to S390_CPU_STATE_LOAD and
>> then immediately afterwards to S390_CPU_STATE_OPERATING, especially
>> considering that both do the same
>>
> 
> Have a look at the specs, wee need to set the load state before setting
> the cpu to operating.
> 
> I can add a comment to make it clearer if you want.

Yes please. I stumbled over this as well before I read the specs.