Re: [PATCH v2 8/9] target/arm: Check addresses for disabled regimes

[Richard Henderson]

On 3/5/20 6:21 AM, Peter Maydell wrote:
>>      if (regime_translation_disabled(env, mmu_idx)) {
>> -        /* MMU disabled. */
>> +        /*
>> +         * MMU disabled.  S1 addresses are still checked for bounds.
>> +         * C.f. AArch64.TranslateAddressS1Off.
>> +         */
>> +        if (is_a64(env) && mmu_idx != ARMMMUIdx_Stage2) {
> 
> This looks weird -- why do we care about whether the current
> EL is aarch64, rather than looking at the controlling EL
> for the translation regime ?

You're right, it should be the aa64-ness of the regime_el.
Thanks,


r~