On 3/4/20 7:41 PM, David Hildenbrand wrote: > On 04.03.20 12:42, Janosch Frank wrote: >> Status storing is not done by QEMU anymore, but is handled by SIE. >> >> Signed-off-by: Janosch Frank <[email protected]> >> Reviewed-by: Thomas Huth <[email protected]> >> --- >> target/s390x/helper.c | 4 ++++ >> target/s390x/sigp.c | 1 + >> 2 files changed, 5 insertions(+) >> >> diff --git a/target/s390x/helper.c b/target/s390x/helper.c >> index ed72684911..8b91ed68f0 100644 >> --- a/target/s390x/helper.c >> +++ b/target/s390x/helper.c >> @@ -246,6 +246,10 @@ int s390_store_status(S390CPU *cpu, hwaddr addr, bool >> store_arch) >> hwaddr len = sizeof(*sa); >> int i; >> >> + if (cpu->env.pv) { >> + return 0; >> + } >> + >> sa = cpu_physical_memory_map(addr, &len, true); >> if (!sa) { >> return -EFAULT; >> diff --git a/target/s390x/sigp.c b/target/s390x/sigp.c >> index c604f17710..e1c8071464 100644 >> --- a/target/s390x/sigp.c >> +++ b/target/s390x/sigp.c >> @@ -497,6 +497,7 @@ void do_stop_interrupt(CPUS390XState *env) >> if (s390_cpu_set_state(S390_CPU_STATE_STOPPED, cpu) == 0) { >> qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN); >> } >> + /* Storing will occur on next SIE entry for protected VMs */ > > I think this comment would be better next to the cpu->env.pv check.
Ack
>
>> if (cpu->env.sigp_order == SIGP_STOP_STORE_STATUS) {
>> s390_store_status(cpu, S390_STORE_STATUS_DEF_ADDR, true);
>> }
>>
>
>
> Apart from that
>
> Reviewed-by: David Hildenbrand <[email protected]>
Thanks
signature.asc
Description: OpenPGP digital signature
