On 3/1/20 2:40 AM, Eric Auger wrote:
> + /* Check chosen version is effectively supported by the host */
> + if (vms->gic_version == VIRT_GIC_VERSION_2 &&
> + !(probe_bitmap & KVM_ARM_VGIC_V2)) {
> + error_report("host does not support in-kernel GICv2
> emulation");
> + exit(1);
> + } else if (vms->gic_version == VIRT_GIC_VERSION_3 &&
> + !(probe_bitmap & KVM_ARM_VGIC_V3)) {
> + error_report("host does not support in-kernel GICv3
> emulation");
> + exit(1);
> + }
Indentation is wrong here.
> + case VIRT_GIC_VERSION_HOST:
> + error_report("gic-version=host requires KVM");
> + exit(1);
> + default: /* explicit V2/V3 are left untouched */
> + break;
> }
I'd prefer to just list V2 and V3 here explicitly, instead of the default.
It'll be nicer with gic_version changed to an enum.
With those changes,
Reviewed-by: Richard Henderson <[email protected]>
r~
