Re: [PATCH v4 2/4] target/riscv: configure and turn on vector extension from command line

[LIU Zhiwei]

On 2020/2/11 23:56, Richard Henderson wrote:

On 2/10/20 8:12 AM, LIU Zhiwei wrote:

+            if (cpu->cfg.vlen > RV_VLEN_MAX || cpu->cfg.vlen < 128) {
+                error_setg(errp,
+                       "Vector extension implementation only supports VLEN "
+                       "in the range [128, %d]", RV_VLEN_MAX);
+                return;
+            }
+            if (!is_power_of_2(cpu->cfg.elen)) {
+                error_setg(errp,
+                       "Vector extension ELEN must be power of 2");
+                return;
+            }
+            if (cpu->cfg.elen > 64) {
+                error_setg(errp,
+                       "Vector extension ELEN must <= 64");
+                return;
+            }

ELEN should use the same "only supports ELEN in the range" language as VLEN.

OK. I will printf "only supports ELEN in the range[8, 64]".

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~