On Wed, 29 Jan 2020, Philippe Mathieu-Daudé wrote:
> >
> > This would allow the host to change the value of the Silicon Revision
> > register.
> How the guest can modify it? We have:
>
> 589 static void dp8393x_write(void *opaque, hwaddr addr, uint64_t data,
> 590 unsigned int size)
> 591 {
> 592 dp8393xState *s = opaque;
> 593 int reg = addr >> s->it_shift;
> 594
> ...
> 597 switch (reg) {
> ...
> 602 /* Prevent write to read-only registers */
> ...
> 606 case SONIC_SR:
> ...
> 608 DPRINTF("writing to reg %d invalid\n", reg);
> 609 break;
>
My mistake. I had completely overlooked that logic.
I'll revise this patch in accordance with your suggestion.
