Philippe Mathieu-Daudé <[email protected]> writes:
> From: Michael Rolnik <[email protected]> > > These were designed to facilitate testing but should provide enough > function to be useful in other contexts. Only a subset of the functions > of each peripheral is implemented, mainly due to the lack of a standard > way to handle electrical connections (like GPIO pins). > > Signed-off-by: Sarah Harris <[email protected]> > Message-Id: <[email protected]> > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > [rth: Squash info mtree fixes and a file rename from f4bug, which was:] > Suggested-by: Aleksandar Markovic <[email protected]> > Signed-off-by: Richard Henderson <[email protected]> > [PMD: Use qemu_log_mask(LOG_UNIMP), replace goto by return] > Signed-off-by: Philippe Mathieu-Daudé <[email protected]> > --- <snip> > --- /dev/null > +++ b/include/hw/timer/atmel_timer16.h > @@ -0,0 +1,94 @@ > +/* > + * Atmel AVR 16 bit timer > + * > + * Copyright (c) 2018 University of Kent > + * Author: Ed Robbins No sign off from the author here? > --- /dev/null > +++ b/hw/timer/atmel_timer16.c > @@ -0,0 +1,605 @@ <snip> > + > +/* Helper macros */ > +#define VAL16(l, h) ((h << 8) | l) > +#define DB_PRINT(fmt, args...) /* Nothing */ > +/*#define DB_PRINT(fmt, args...) printf("%s: " fmt "\n", __func__, ## > args)*/ Format strings are likely to bitrot. Either use a if (GATE) or tracepoints. <snip> Otherwise: Reviewed-by: Alex Bennée <[email protected]> -- Alex Bennée
