On 1/18/20 2:27 PM, Markus Armbruster wrote:
Philippe Mathieu-Daudé <[email protected]> writes:

On 1/18/20 8:10 AM, Markus Armbruster wrote:
Philippe Mathieu-Daudé <[email protected]> writes:

Most of these developers have the Signed-off-by tag properly
written, but not the author/commiter name. Fix this.
Also we incorrectly wrote Arei Gonglei name, update and reorder.

git-log does not use this file by default until you specify the
--use-mailmap flag:

    $ git log --use-mailmap

Signed-off-by: Philippe Mathieu-Daudé <[email protected]>
---
   .mailmap | 29 ++++++++++++++++++++++++++++-
   1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/.mailmap b/.mailmap
index 3816e4effe..1a859d9e65 100644
--- a/.mailmap
+++ b/.mailmap
@@ -56,6 +56,10 @@ Aaron Lindsay <[email protected]>
   Alexey Gerasimenko <[email protected]>
   Alex Ivanov <[email protected]>
   Andreas Färber <[email protected]>
+Andreas Färber <[email protected]>
+Andreas Färber <[email protected]> <andreas.faerber>
+Arei Gonglei <[email protected]>
+Arei Gonglei <[email protected]> <root@ceth6.(none)>

I can't find this one in git-log.

I was first surprised:

$ git log -1 3b08098b40
commit 3b08098b409c0fb28f85436ba1adeb1d401ec8f7
Author:     Gonglei <[email protected]>
AuthorDate: Wed Dec 3 18:25:46 2014 +0000
Commit:     root <root@ceth6.(none)>
CommitDate: Mon Dec 22 14:39:21 2014 +0800

     bootdevice: add validate check for qemu_boot_set()

     Signed-off-by: Gonglei <[email protected]>
     Reviewed-by: Markus Armbruster <[email protected]>

After thinking for a bit I remembered I once changed my default format:

$ git config format.pretty
fuller

Aha!  Could've thought of this myself...

I suppose I should add this in the commit description.

Can't hurt.

OK will do, thank for the review!

[...]
   Shin'ichiro Kawasaki <[email protected]>
   Shin'ichiro Kawasaki <[email protected]>
+Siwei Zhuang <[email protected]>

It's actually spelled [email protected] in git-log.
Shouldn't matter.

Correct:

$ git shortlog -e 6478dd745d~..6478dd745d
Zhuang, Siwei (Data61, Kensington NSW) <[email protected]> (1):
       hw/riscv: Add optional symbol callback ptr to riscv_load_kernel()

$ git shortlog -e 6478dd745d~..6478dd745d
Siwei Zhuang <[email protected]> (1):
       hw/riscv: Add optional symbol callback ptr to riscv_load_kernel()

Suggest to adjust case if you respin.

Thanks for caring checking all entries!

Reviewed-by: Markus Armbruster <[email protected]>

[...]



Reply via email to