On 08/01/2020 15.46, Daniel Henrique Barboza wrote:
> 'out' label from write_event_mask() and and write_event_data()
> can be replaced by 'return'.
> 
> The 'out' label from read_event_data() can also be replaced.
> However, as suggested by Cornelia Huck, instead of simply
> replacing the 'out' label, let's also change the code flow
> a bit to make it clearer that sccb events are always handled
> regardless of the mask for unconditional reads, while selective
> reads are handled if the mask is valid.
> 
> CC: Cornelia Huck <[email protected]>
> CC: Thomas Huth <[email protected]>
> CC: Halil Pasic <[email protected]>
> CC: Christian Borntraeger <[email protected]>
> Signed-off-by: Daniel Henrique Barboza <[email protected]>

Wow, that cleans up quite a bit of goto-spaghetti-code!

Reviewed-by: Thomas Huth <[email protected]>


Reply via email to