On Mon, 6 Jan 2020 at 18:01, Peter Xu <[email protected]> wrote: > > On Mon, Jan 06, 2020 at 05:40:15PM +0000, Peter Maydell wrote: > > [...] > > > So we're OK to not do this because tests/iothread.c's > > main loop doesn't call g_main_loop_run(), and it doesn't > > provide an iothread_get_g_main_context() ? > > > > I'm kind of inclined towards being lazy and sticking with > > what this patch has, because: > > * it matches the real iothread.c, which reduces the possiblity > > of future surprise bugs due to things not matching up > > * it's already been reviewed > > * it saves me having to do a respin and retest > > > > But if people would prefer these bits deleted I'll stop > > being lazy :-) > > Please feel free to be lazy and fix the test sooner (and that's why I > offered my r-b :).
Thanks; I've applied this to master (though some other problem with the NetBSD VM test run seems to have crept in while I was ignoring failures on the assumption they were due to this bug :-( ) -- PMM
