On Wednesday, December 18, 2019, Michael Rolnik <[email protected]> wrote:
> Include AVR maintaners in MAINTAINERS file > > Signed-off-by: Michael Rolnik <[email protected]> > --- > MAINTAINERS | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 740401bcbb..9ed886106a 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -163,6 +163,27 @@ S: Maintained > F: hw/arm/smmu* > F: include/hw/arm/smmu* > > +AVR TCG CPUs > +M: Michael Rolnik <[email protected]> > +R: Sarah Harris <[email protected]> > +S: Maintained > +F: target/avr/ > +F: tests/acceptance/machine_avr6.py > +F: default-configs/avr-softmmu.mak > +F: gdb-xml/avr-cpu.xml > + > +AVR Machines > +M: Michael Rolnik <[email protected]> > +R: Sarah Harris <[email protected]> > +S: Maintained > +F: hw/avr/ > +F: hw/char/avr_usart.c > +F: include/hw/char/avr_usart.h > +F: hw/timer/avr_timer16.c > +F: include/hw/timer/avr_timer16.h > +F: hw/misc/avr_mask.c > +F: include/hw/misc/avr_mask.h > + This second section "AVR Machines" is in the wrong place. (Philippe already brought this to your attention, but it looks you did not understand his point.) Please move this section further down the MAINTAINERS file, after "Alpha machines" and "Arm machines". Also, header file and source files are in the wrong order in your list. Headrrs should always preceede source files Yours, Aleksandar > CRIS TCG CPUs > M: Edgar E. Iglesias <[email protected]> > S: Maintained > -- > 2.17.2 (Apple Git-113) > >
